-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue module now depends on typescript module #10840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdos
added
area: feature request 💡
generator: internal
theme: typescript
and removed
area: triage
labels
Sep 14, 2024
murdos
force-pushed
the
vue-depends-on-typescript
branch
from
September 14, 2024 21:34
beeb7bc
to
e3c05a0
Compare
…eady declared in typescript module
…llow factorizing/splitting a block of operations on a moduleBuilder
It's currently only used in typescript module, no other client module uses it. We might reintroduce it in future, if needed.
murdos
force-pushed
the
vue-depends-on-typescript
branch
from
September 14, 2024 21:37
e3c05a0
to
eee147a
Compare
…ndatory|Optional} replacer to the replacements This allows reusing replacers, and improves readability and maintainability of the code
murdos
force-pushed
the
vue-depends-on-typescript
branch
from
September 14, 2024 21:39
eee147a
to
df4f8f6
Compare
murdos
requested review from
renanfranca,
DamnClin,
pascalgrimaud and
qmonmert
September 15, 2024 08:23
DamnClin
approved these changes
Sep 15, 2024
qmonmert
approved these changes
Sep 15, 2024
renanfranca
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, @murdos ! Great work!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: feature request 💡
$$ bug-bounty $$
https://www.jhipster.tech/bug-bounties/
generator: internal
theme: typescript
$500
https://www.jhipster.tech/bug-bounties/
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10421