Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue module now depends on typescript module #10840

Merged
merged 15 commits into from
Sep 15, 2024

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Sep 14, 2024

See #10421

…ndatory|Optional} replacer to the replacements

This allows reusing replacers, and improves readability and maintainability of the code
@murdos murdos marked this pull request as ready for review September 15, 2024 08:22
@pascalgrimaud pascalgrimaud added the $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ label Sep 15, 2024
@pascalgrimaud pascalgrimaud added the $500 https://www.jhipster.tech/bug-bounties/ label Sep 15, 2024
Copy link
Contributor

@renanfranca renanfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @murdos ! Great work!

@murdos murdos merged commit 3500a22 into jhipster:main Sep 15, 2024
34 checks passed
@murdos murdos deleted the vue-depends-on-typescript branch September 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal theme: typescript $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants